feat: add provider-wide model disable flow#577
Open
NaNomicon wants to merge 7 commits intodecolua:masterfrom
Open
feat: add provider-wide model disable flow#577NaNomicon wants to merge 7 commits intodecolua:masterfrom
NaNomicon wants to merge 7 commits intodecolua:masterfrom
Conversation
Always call fetchConnections() after PATCH regardless of res.ok, so optimistic state is replaced by authoritative backend state. Also update disabledModels across all connections (not just active ones) so newly-activated connections inherit the correct disabled list.
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <[email protected]>
Author
|
Verification note: I validated the provider-disable behavior on the fork branches before splitting this PR. When re-verifying the cherry-picked upstream branch locally, the existing upstream |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/v1/models, reject direct and alias-resolved requests for disabled models, and keep combo execution aligned with absent-model semantics/modelsimport, and exclude disabled models from combo search resultsWhy
Temporarily stopping use of a provider model currently requires destructive remove/re-add behavior, and imports from
/modelscan reintroduce models in inconsistent ways. This change makes disable state explicit, non-destructive, and enforced consistently across discovery, runtime, UI, import, and combo selection.Notes
disabledModelsstores bare model IDs and takes precedence overenabledModels